[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] UI improvement for svnadmin verify

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 22 Feb 2008 18:50:34 -0500

Eric Gillespie <epg_at_google.com> writes:
> --- subversion/libsvn_repos/dump.c (revision 29557)
> +++ subversion/libsvn_repos/dump.c (working copy)
> @@ -1193,7 +1197,7 @@
> for (rev = start_rev; rev <= end_rev; rev++)
> {
> svn_delta_editor_t *dump_editor;
> - void *dump_edit_baton;
> + struct edit_baton *dump_edit_baton;
> const svn_delta_editor_t *cancel_editor;
> void *cancel_edit_baton;
> svn_fs_root_t *to_root;
> @@ -1202,9 +1206,10 @@
>
> /* Get cancellable dump editor, but with our close_directory handler. */
> SVN_ERR(get_dump_editor((const svn_delta_editor_t **)&dump_editor,
> - &dump_edit_baton, fs, rev, "",
> + (void *)&dump_edit_baton, fs, rev, "",
> svn_stream_empty(pool), feedback_stream,
> start_rev, FALSE, iterpool));
> + dump_edit_baton->verify = TRUE;
> dump_editor->close_directory = verify_close_directory;
> SVN_ERR(svn_delta_get_cancellation_editor(cancel_func, cancel_baton,
> dump_editor, dump_edit_baton,

I think the way to do this is to pass a new boolean 'verify' argument
to get_dump_editor(), which in turn is responsible for setting the
boolean in the baton. (I.e., the baton should always remain 'void *'
to the outside caller.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-23 00:50:44 CET

This is an archived mail posted to the Subversion Dev mailing list.