[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add URL support for propset and propdel and fix URL support for propedit

From: <kmradke_at_rockwellcollins.com>
Date: Fri, 22 Feb 2008 14:11:55 -0600

Karl Fogel <kfogel_at_red-bean.com> wrote on 02/22/2008 02:04:59 PM:
> kmradke_at_rockwellcollins.com writes:
> > Needed a way to specify a "base revision", because of the possible
> > race condition between looking at the properties and then
> > performing a command directly on the repository.
> >
> > We kicked around a --base-rev parameter in another thread, but
> > it was easier for me to "overload" the meaning of -r here.
> >
> > Not using -r and using some other parameter is definitely a
> > (probably less confusing) option.
> >
> > We could also assume "HEAD" (others didn't like this)
> >
> > Is peg revision syntax appropriate? (no idea on this)
>
> FWIW, I like the "-rACTUAL_NUMBER" solution a lot. It protects
> against any possibility of race condition.
>
> It's okay if HEAD is different from ACTUAL_NUMBER, as long as the
> property still has the value in HEAD that it did in ACTUAL_NUMBER,
> of course.

That is an interesting improvement if we stay with using -r.

Personally, I'm ok with assuming HEAD and putting an appropriate
warning in the help, but I'll try and make the patch do
whatever the majority prefers.

Kevin R.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-22 21:11:32 CET

This is an archived mail posted to the Subversion Dev mailing list.