[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Followup to r29374.

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 22 Feb 2008 11:25:30 -0500

Kamesh Jayachandran <kamesh_at_collab.net> writes:
> I am not sure about the value of change!. I think this is needed only
> at the API level need not be at the usage level inside functions.
>
> Even if we change all the occurance of 'apr_hash_t *' with
> svn_mergeinfo_t we peek at the corresponding variable as pure hashes
> so we don't gain anything by 'abstracting the types' alone without
> abstracting its accessors.
>
> If we love abstracting this data-type we need to provide its own
> accessor routines i.e we should not blatantly use apr_hash_get/set.

This is something we're going to need to decide -- currently, we have
been changing internal code to use the types too...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-22 17:28:40 CET

This is an archived mail posted to the Subversion Dev mailing list.