dglasser_at_gmail.com wrote on 02/21/2008 04:46:09 PM:
> On Thu, Feb 21, 2008 at 5:36 PM, Eric Gillespie <epg_at_pretzelnet.org>
wrote:
> > "David Glasser" <glasser_at_davidglasser.net> writes:
> >
> > > I find "-r" to be a little confusing here. It's different from
most
> > > other svn commands, where "-r" really means "select r42 instead of
the
> > > default revision (eg HEAD)".
> >
> > This is selecting, in a way. I know what you're getting at, but
> > I'm not sure it's a confusion non-svn-hackers will get or even
> > care about. "I'm specifying a revision, aren't I?" I don't
> > know; I'm not going to cry if we go with --base-rev ;->.
>
> Sure, but there are no other commands that I know of where there's
> only one legal range for "-r", and everything else gets an error
> message.
>
> On the other hand I've been bikeshedding too much this week. I'll
> happily apply any reasonable patch, I mean.
Patch will be coming (tomorrow most likely), but I noticed this in
propedit-cmd.c around line 264:
if (ctx->log_msg_func3)
SVN_ERR(svn_cl__make_log_msg_baton(&(ctx->log_msg_baton3),
opt_state, NULL,
ctx->config,
subpool));
ctx->revprop_table = opt_state->revprop_table;
err = svn_client_propset3(&commit_info,
pname_utf8, edited_propval,
target,
svn_depth_empty, opt_state->force,
base_rev, NULL,
ctx, subpool);
if (ctx->log_msg_func3)
SVN_ERR(svn_cl__cleanup_log_msg(ctx->log_msg_baton2,
err));
else if (err)
return err;
Shouldn't the svn_cl__cleanup_log_msg() call be using
"ctx->log_msg_baton3"?
Kevin R.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-21 23:57:39 CET