[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29439 - trunk/subversion/libsvn_ra_neon

From: Joe Orton <jorton_at_redhat.com>
Date: Wed, 20 Feb 2008 16:07:19 +0000

On Wed, Feb 20, 2008 at 10:28:36AM -0500, Karl Fogel wrote:
> joe_at_tigris.org writes:
> > Log:
> > * subversion/libsvn_ra_neon/session.c
> > (parse_capabilities): Simplify (and optimise) to retrieve the DAV:
> > response header directly rather than unnecessarily iterating through
> > all the returned header fields to find it. Also fix the comment.
>
> Thanks, Joe.
>
> I have a vague memory that there was some specific reason why I didn't
> use ne_get_response_header() in the first place -- that I tried it and
> some edge case didn't work the way I expected. I've searched back
> through the logs and my mailbox to see if I could find out more, but
> didn't turn up anything, unfortunately. So if you're positive that
> the new code is equivalent to the old code, I'll relax and chalk it up
> to cosmic rays on my brain... ?

It's logically equivalent, yup. Both interfaces operate on the same
hash table of name/value pairs, there is no processing done in either
case other than looking up names in that hash table (the value merging
happens earlier, for example).

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-20 17:07:37 CET

This is an archived mail posted to the Subversion Dev mailing list.