[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Repository root relative url support in svn CLI -- REDUX

From: Branko Čibej <brane_at_xbc.nu>
Date: Sun, 17 Feb 2008 20:23:59 +0100

Troy Curtis Jr wrote:
> On Feb 17, 2008 7:52 AM, Branko Čibej <brane_at_xbc.nu> wrote:
>
>> Troy Curtis Jr wrote:
>>
>>
>>> +svn_boolean_t
>>> +svn_path_is_relative_url(const char *url)
>>> +{
>>> + return(0 == strncmp("^/", url, 2) ? TRUE : FALSE);
>>> +}
>>>
>> =-O
>>
>> I find this to be most inelegant.
>>
>> return !strncmp("^/", url, 2);
>>
>> -- Brane
>>
>>
>
> Yeah but that is not the right return type now is it?

Of course it is. It's a safe implicit conversion and no sane compiler in
the word should look twice at it.

> To each his own right?
>

Oh, yes ... I know some people complain that an 80-column line limit is
too narrow because their very descriptive identifiers are 40 characters
long ... :p

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-17 20:24:27 CET

This is an archived mail posted to the Subversion Dev mailing list.