[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29360 - trunk/subversion/mod_dav_svn/reports

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 15 Feb 2008 00:07:21 -0500

"David Glasser" <glasser_at_davidglasser.net> writes:
> Out of curiosity, why aren't you using svn_repos_has_capability in
> mod_dav_svn (like the other two servers)?

Hmm, no good reason, actually. Six of one, half dozen of the other?

> That would also let you sidestep this issue for now...

Well, no: whether we detect the incapability by getting an error from
svn_whatever_get_mergeinfo() vs by asking svn_repos_has_capability(),
is unrelated to how we report that incapability to the client.

As you pointed out, we *could* have a non-error-ish way in the
protocol of saying "mergeinfo isn't supported". However, since we
explicitly have HTTP_NOT_IMPLEMENTED around for this sort of thing
(not to mention SVN_ERR_UNSUPPORTED_FEATURE), doing an error
transmission back to the client seemed like the cleanest fit to me.

While I could be persuaded that the in-protocol answer would be
preferable, the persuasiveness of any given argument on that topic
would not be changed by how mod_dav_svn determined the presence or
absence of mergeinfo support... Or so I think, but tell me if I'm
missing something.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-15 06:07:31 CET

This is an archived mail posted to the Subversion Dev mailing list.