Re: [PATCH] Don't blow out scrollback in conflict handler prompt diff

Eric Gillespie <epg_at_google.com> writes:

> Martin Furter <mf_at_rola.ch> writes:
>
> > I think with the patch in issue #2791 (which adds pipe support 20
> > svn_io_start_cmd) your new function svn_stream_for_pager would be much
> > shorter (There's also a patch which shortens run_hook_cmd).
>
> Ah, nice! I didn't realize apr_proc_foo already took care of all
> this; it would be a shame to duplicate it. Does anyone object to
> the svn_io_start_cmd2 patch? I would change the three pre-processor
> macros to enums, but otherwise it looks good.

Actually, I see that we always use macros for these, e.g.

#define SVN_AUTH_SSL_NOTYETVALID 0x00000001
#define SVN_AUTH_SSL_EXPIRED 0x00000002
...

So I'd say the patch looks good as is.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-12 01:59:49 CET