[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29085 - in trunk/subversion: libsvn_client tests/cmdline

From: Paul Burba <ptburba_at_gmail.com>
Date: Mon, 11 Feb 2008 11:46:59 -0500

On Feb 11, 2008 10:34 AM, Paul Burba <ptburba_at_gmail.com> wrote:
>
> On Feb 7, 2008 4:23 PM, David Glasser <glasser_at_davidglasser.net> wrote:
> > On Feb 4, 2008 9:41 AM, Paul Burba <ptburba_at_gmail.com> wrote:
> > > On Feb 1, 2008 5:37 PM, David Glasser <glasser_at_davidglasser.net> wrote:
> > >
> > > Hi David, appreciate you taking a look at this, comments below.
> > >
> > >
> > > > On Jan 30, 2008 11:34 AM, <pburba_at_tigris.org> wrote:

<snip>

> > > > (Also,
> > > > shouldn't there be a space after the ":" in the property value?)
> > >
> > > No, our created mergeinfo has no whitespace. Although it appears our
> > > parser allows whitespace when using svn propset, but then it doesn't
> > > get interpreted correctly. I'll look into this some more and start a
> > > separate thread if necessary.
> >
> > Huh, wonder why I thought that.
>
> Starting another thread on this.

Doh, disregard that. svn_mergeinfo_parse() does handle spaces *after*
the ':' correctly. I had tried a quick example with a space *before*
the ':', but that of course is a different filename! "/trunk" !=
"/trunk ".

Also, when I said "our created mergeinfo has no whitespace" I meant
that svn_mergeinfo_to_stringbuf() and svn_rangelist_to_stringbuf()
produces mergeinfo/rangelists without any whitespace -- i.e. "svn
merge" creates mergeinfo without whitespace.

The only way I know of that can introduce mergeinfo with whitespace
after the ':' is "svn propset svn:mergeinfo ...". But I see no harm
with this as "/trunk:4,7,10-12" and "/trunk:4, 7, 10-12" both get
parsed to the equivalent mergeinfo hash.

Paul

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-11 17:47:11 CET

This is an archived mail posted to the Subversion Dev mailing list.