[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29250 - trunk/subversion/libsvn_fs_fs

From: David Glasser <glasser_at_davidglasser.net>
Date: Fri, 8 Feb 2008 16:52:10 -0800

On Feb 8, 2008 4:19 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>
> On Feb 8, 2008 3:59 PM, David Glasser <glasser_at_davidglasser.net> wrote:
> > On Feb 8, 2008 3:47 PM, <glasser_at_tigris.org> wrote:
> > > Author: glasser
> > > Date: Fri Feb 8 15:47:56 2008
> > > New Revision: 29250
> > >
> > > Log:
> > > Yet another node-origins-cache-for-FSFS implementation! This one
> > > hopefully is the best of all worlds: create a new style of node
> > > IDs which encode the origin revision directly into the node ID, but
> > > continue to have an on-disk cache for old node IDs, but save disk
> > > space by using cmpilato's patch to store up to 36 IDs in each file.
> > >
> > > Note that because new node IDs don't need to be cached, we can remove
> > > the "gather new node IDs during commit and cache them in bulk" code,
> > > which in fact even removes the need for any bulk-cache-writing code at
> > > all.
> > >
> > > Also, properly handle node-IDs that have never been committed.
> >
> > Woo, finally.
> >
> > Note that testing this is a bit of a pain, since a bunch of the code
> > (the cache part) only is used for legacy repositories, and the test
> > suite isn't creating any of them. So I haven't really tested it,
> > though it's based on cmpilato's patch, which he tested.
>
> Awesome David! thanks.
>
> Out of curiosity could we have a test set that use the
> --pre-whatever-compat flag to create old repositories? Would that
> cause the other cache to be created?

True, that would cause the other cache to be created (and that happens
if you set the server-minor-version flag to 4). Wouldn't test the
overlap behavior though.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-09 01:52:19 CET

This is an archived mail posted to the Subversion Dev mailing list.