[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: special property for text types

From: John Peacock <john.peacock_at_havurah-software.org>
Date: Thu, 07 Feb 2008 14:09:29 -0500

C. Michael Pilato wrote:
> Karl Fogel wrote:
>> - svn_mime_type_is_binary() returning false
>> - svn:eol-style being present at all
>> - new special property ('svn:is-text' or whatever) being present.
>
> I like the thinking here, but would prefer to optimize this a bit,
> perhaps by simply allowing svn:eol-style to accept a value which means
> "don't do any EOL conversion, but note that this is line-based". maybe
> "*" or "" or something.

If we wanted to overload the meaning on svn:eol-style to include
"textiness", that would certainly be a much smaller change. I've been
slowly working my way through the code base and adding a new property
(whatever it is called) will be a much harder slog (to the point that I
don't know if it would make 1.5). There are way too many places that
assume svn_mime_type_is_binary() is all that needs to be checked, and at
points where there isn't much to go on besides the already cached
properties.

I can't look at this tonight, but maybe over the weekend, if that is the
direction that seems likely to win approval...

John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-07 20:09:46 CET

This is an archived mail posted to the Subversion Dev mailing list.