[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29189 - in trunk/subversion: include libsvn_wc svn tests/cmdline tests/cmdline/getopt_tests_data

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 05 Feb 2008 13:26:56 -0800

Eric Gillespie wrote:
> Karl Fogel <kfogel_at_red-bean.com> writes:
>
>> Eric Gillespie <epg_at_pretzelnet.org> writes:
>>>> This is the one part of the change I worry about: the addition of the
>>>> "-all" suffix to in the 'mine' and 'theirs' cases can make that prompt
>>>> go longer than 80 columns:
>>>>
>>>> Select: (p)ostpone, (M)ine-all, (T)heirs-all, (r)esolved, (h)elp for more options:
>>> Well, these "all" options are not going to be here much longer,
>>> right? They'll be relegated to "more options" once we have the
>>> new mine/theirs. So why worry about it?
>> Yes, that's true. But 1.6 isn't happening tomorrow, either; I think
>> it's worth paying attention to presentation for as long as 1.5.x is
>> the latest.
>
> Ah, 1.6! I somehow thought you were going to be adding the new
> features soon. Let's not knowingly go past 80 columns with that
> prompt in a formal release.
>
> This doesn't look too bad:
>
> Select:
> (p)ostpone, (M)ine-all, (T)heirs-all, (r)esolved, (h)elp for more options:
>
> but how about:
>
> Select: (p)ostpone, (M)ine-all, (T)heirs-all, (r)esolved,
> (h)elp for more options:

If we're wrapping lines anyway, I'd really prefer to make full use of
grammar here. Something like:

    Select: (p)ostpone, all of (M)ine, all of (T)heirs, (r)esolved,
            (h)elp for more options:

"(M)ine-all" and "(T)heirs-all" is so ... inhuman.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-02-05 22:27:06 CET

This is an archived mail posted to the Subversion Dev mailing list.