[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_fs_paths_changed node_rev_id field has always been broken on FSFS

From: David Glasser <glasser_at_davidglasser.net>
Date: Fri, 1 Feb 2008 12:45:18 -0800

Just a note --- this isn't a huge priority now, but might as well get
this in the archives.

cmpilato and I noticed that FSFS has always been buggy in writing out
changed-path entries to rev files. Specifically, the temporary
changed-paths entry in the transaction directory stores the
transaction node-rev-ID, not the final revision one;
write_final_changed_path_info is *supposed* to translate that into a
permanent node-rev-id, but the conditional is wrong: it only does the
conversion if the ID in question is a permanent ID, which is the
opposite of what is necessary.

We could just flip the ! in the conditional. You'd also probably need to
revert r27161; except I actually did r27161 for a reason (I worried
about corruption if a transaction was partway through being committed,
failed, and was later re-opened). Perhaps an in-memory hash mapping
temporary to permanent node-rev-IDs would be best.


David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-01 21:45:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.