[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29113 - in branches/svnadmin-upgrade/subversion: libsvn_fs libsvn_fs_base libsvn_fs_fs

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 01 Feb 2008 08:27:02 -0500

David Glasser wrote:
>> - SVN_ERR(svn_io_make_dir_recursively(svn_path_join(path,
>> - PATH_TXN_PROTOS_DIR,
>> - pool),
>> - pool));
>> + {
>> + /* We don't use path_txn_proto_rev() here because it expects
>> + we've already bumped our format. */
>
> Slightly misleading comment: you don't use path_txn_proto_rev because
> it doesn't actually tell you what you need (it takes a specific txn as
> argument).

No, my comment expresses exactly why I don't use that function. The
function makes a decision about which path to use (pre-1.5 or 1.5) based on
the format stored in the svn_fs_t object. Since I haven't bumped that
number yet, it would choose the old-style path and do the wrong thing.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-02-01 14:30:55 CET

This is an archived mail posted to the Subversion Dev mailing list.