[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29118 - trunk/subversion/libsvn_fs_fs

From: David Glasser <glasser_at_davidglasser.net>
Date: Thu, 31 Jan 2008 19:34:18 -0800

On Jan 31, 2008 5:42 PM, <kfogel_at_tigris.org> wrote:
> Author: kfogel
> Date: Thu Jan 31 17:42:45 2008
> New Revision: 29118
>
> Log:
> * subversion/libsvn_fs_fs/fs_fs.c
> (ensure_revision_exists): Doc improvements, following up to r29106.
>
>
> Modified:
> trunk/subversion/libsvn_fs_fs/fs_fs.c
>
> Modified: trunk/subversion/libsvn_fs_fs/fs_fs.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/fs_fs.c?pathrev=29118&r1=29117&r2=29118
> ==============================================================================
> --- trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
> +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Thu Jan 31 17:42:45 2008
> @@ -1298,8 +1298,18 @@
> return SVN_NO_ERROR;
> }
>
> -/* Throw an error if the given revision is newer than the current
> - youngest revision. */
> +/* Return SVN_ERR_FS_NO_SUCH_REVISION if the given revision is newer
> + than the current youngest revision or is simply not a valid
> + revision number, else return success.
> +
> + FSFS is based around the concept that commits only take effect when
> + the number in "current" is bumped. Thus if there happens to be a rev
> + or revprops file installed for a revision higher than the one recorded
> + in "current" (because a commit failed between installing the rev file
> + and bumping "current", or because an administrator rolled back the
> + repository by resetting "current" without deleting rev files, etc), it
> + ought to be completely ignored. This function provides the check
> + by which callers can make that decision. */
> static svn_error_t *
> ensure_revision_exists(svn_fs_t *fs,
> svn_revnum_t rev,

Thanks Karl. I need to stop putting explanations in log messages...

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-01 09:12:25 CET

This is an archived mail posted to the Subversion Dev mailing list.