[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a regression from 1.4 in trunk and branch

From: Augie Fackler <durin42_at_gmail.com>
Date: Wed, 30 Jan 2008 15:03:41 -0600

On Jan 30, 2008, at 2:57 PM, C. Michael Pilato wrote:

> Augie Fackler wrote:
>> On Jan 30, 2008, at 2:41 PM, C. Michael Pilato wrote:
>>> Of interest (to me, at least) is how we managed to get ahold of
>>> the non-canonicalized path that we currently write to the entries
>>> file. I mean, the first thing our command-line client does with
>>> the paths provided to subcommands is canonicalize them, I
>>> thought. What gives?
>> The path is the computed repository root - I haven't figured out in
>> the code where that happens yet, but it looks to my eye like the
>> repository root is being computed with the hostname and the path
>> separate, so that when the path is just / it isn't stored in a
>> canonical form, but if it was at /foo/ it would get stored as /foo
>> I was seeing the bug when I was checking out http://svn.perian.org/trunk
>> , which isn't the repo root, so svn must be computing the repo root
>> of http://svn.perian.org/ on its own somewhere...
>
> Oh, yes, right -- forgot that you were probably checking out
> something deeper than the root. Yes, each RA implementation does
> this sort of root calculation. Your solution will work, but still
> leaves us with non-canonicalized paths being passed around the
> libraries in memory during the checkout. I would suggest making the
> four RA layers do this canonicalization at the moment they discern
> the repository root.

Ah, that information comes from the RA layer (I was just trying to
figure this out) - I'll go inspect them all and make sure they DTRT
for this case. Should I keep the original part of the patch and
include it with the work on the RA layer?

>
>
> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet <> www.collab.net <> Distributed Development On
> Demand
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-30 22:03:53 CET

This is an archived mail posted to the Subversion Dev mailing list.