Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb util

Hi Mike

On Jan 29, 2008 12:37 PM, <cmpilato_at_tigris.org> wrote:
> Author: cmpilato
> Date: Tue Jan 29 12:37:29 2008
> New Revision: 29076
>
> Log:
> Bump the libsvn_fs_base format number, and disallow node-origin and
> mergeinfo calculations and queries on older versions of the schema.
> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
> don't auto-upgrade the schema.
>

After this commit this Ruby bindings test (annotated and slightly modified for
clarity) fails...
-----------------------------------------------------------------------------
    # Do something we can test against in the test repo
    log = "sample log"
    file = "hello.txt"
    path = File.join(@wc_path, file)
    FileUtils.touch(path)

    ctx = make_context(log)
    ctx.add(path)
    commit_info = ctx.commit(@wc_path)
    rev = commit_info.revision

    # Things are as we expect
    assert_equal(log, ctx.log_message(path, rev))

    # Move wholesale the repo folders into a new place
    backup_path = File.join(@tmp_path, "back")

    FileUtils.mv(@fs.path, backup_path)
    FileUtils.mkdir_p(@fs.path)

    # Assert that the repo is wacky
    assert_raises(Svn::Error::RaLocalReposOpenFailed) do
      ctx.log_message(path, rev)
    end

    # Hotcopy from our new place back to the repo location
    Svn::Fs.hotcopy(backup_path, @fs.path)

    # Things are okay again
    assert_equal(log, ctx.log_message(path, rev))
-----------------------------------------------------------------------------
like this:

D:\SVN\src-trunk\subversion\bindings\swig\ruby>test\run-test.rb
test\test_fs.rb -n test_hotcopy
Loaded suite test_fs.rb
Started
E
Finished in 3.254 seconds.

  1) Error:
test_hotcopy(SvnFsTest):
Svn::Error::SvnError:
D:\SVN\src-trunk\subversion\libsvn_subr\io.c:2626 Can't open file
'test\repos\db\format': The file exists.
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_fs_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/fs.rb:47:in `hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_fs.rb:93:in
`test_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_fs.rb:87:in
`assert_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_fs.rb:92:in
`test_hotcopy'

1 tests, 2 assertions, 0 failures, 1 errors
-----------------------------------------------------------------------------

I put traces in svn_io_file_open() and reverted this commit. Before this
change svn_fs_hotcopy() only opened 'test\repos\db\format' once. I reapplied
the changes and sure enough, we are trying to open it a second time.

Perhaps this is not a reasonable test? Or did the bindings test catch
something?

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org