[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28942 - in trunk/subversion: include libsvn_client tests/cmdline

From: David Glasser <glasser_at_davidglasser.net>
Date: Wed, 23 Jan 2008 15:24:44 -0800

On Jan 16, 2008 2:26 PM, <pburba_at_tigris.org> wrote:
> @@ -223,6 +224,13 @@
>
> SVN_ERR(svn_wc_entry(&entry, wcpath, adm_access, FALSE, pool));
>
> + /* Look in WCPATH's parents only if the parents share the same
> + working revision. */
> + if (entry->revision != base_revision)
> + {
> + break;
> + }
> +

Can this be safely relaxed to

if (base_revision < entry->cmt_rev || entry->revision < base_revision)
  break;

?

(Also, stylistically, we usually don't have the braces here, I think.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-24 00:24:55 CET

This is an archived mail posted to the Subversion Dev mailing list.