[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] initialize loop condition in set_prop_merge_state

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 23 Jan 2008 09:01:38 -0600

Olaf,
Thanks for the patches. I haven't reviewed them, but I do have a
comment. In the future, could you start a fresh thread for each patch
(unless it is a subsequent version of the same patch, of course)? If
you reply to an existing post, your mailreader may include metadata that
marks your post as a followup in that thread. Note that simply changing
the subject is not enough to prevent this.

For more information see:
http://subversion.tigris.org/mailing-list-guidelines.html#replying

Thanks,
-Hyrum

Olaf Hering wrote:
> gcc4 complains.
>
> subversion/libsvn_wc/props.c: In function 'svn_wc__merge_props':
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
> subversion/libsvn_wc/props.c:1166: warning: 'state_pos' is used uninitialized in this function
> subversion/libsvn_wc/props.c:1145: note: 'state_pos' was declared here
>
> ---
> subversion/libsvn_wc/props.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/subversion/libsvn_wc/props.c
> +++ b/subversion/libsvn_wc/props.c
> @@ -1160,7 +1160,7 @@ set_prop_merge_state(svn_wc_notify_state
> svn_wc_notify_state_merged,
> svn_wc_notify_state_obstructed,
> svn_wc_notify_state_conflicted };
> - int state_pos, i;
> + int state_pos = 0, i;
>
> if (! state)
> return;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>

Received on 2008-01-23 16:23:35 CET

This is an archived mail posted to the Subversion Dev mailing list.