Re: [PATCH] Replace vdelta with xdelta variant

2008/1/17 Niels Werensteijn <n.werensteijn_at_student.utwente.nl>:

> This is my first contribution to opensource so please tell me everything
> I am doing wrong :)
>
> I have a big binary installer commited in svn. Exporting this binary
> costs a lot of time. I traced this down to vdelta. I noticed that it
> only gets used for chucks which have no source steam. XDelta is supposed
> to be much faster than vdelta. So I thought: why not adjust the xdelta
> algorithm to make a diff from itself. I copy/pasted most of the
> algorithm, adding some minor stuff.

I am confused by this. I assumed someone who understands this more
would respond. Since no one has, I'll try. Have you seen these two
things from past releases?

http://subversion.tigris.org/svn_1.2_releasenotes.html#xdelta

http://subversion.tigris.org/svn_1.4_releasenotes.html#svndiff1

Basically, SVN has already switched from vdelta to xdelta. Now, I
believe you would have to be on 1.4 and have created your repository
and dumped/loaded to get all of the benefits. So I did not know if
your patch was making an incremental improvement for people that have
not been able to do this, or if you just missed that we switched to
xdelta altogether.

Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-18 18:40:27 CET