[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] reintegrate branch mergeinfo authz check (for glasser)

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 09 Jan 2008 23:58:47 -0800

"David Glasser" <glasser_at_davidglasser.net> writes:
>> + for (i = 0; i < mergeinfo->nelts; i++)
>
> Uh, isn't mergeinfo an apr_hash_t **? This is not how you iterate
> over a hash...

WTF? It *compiled*, sheesh. (Haven't tested at all yet; I just
wanted your review on the general approach, though am very glad to
have you spot things like this too :-) ).

>> + {
>> + const char *path = APR_ARRAY_IDX(paths, i, char *);
>
> ... and this should be pulling from mergeinfo, not paths.

yup.

Thanks!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-10 05:58:58 CET

This is an archived mail posted to the Subversion Dev mailing list.