[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: changes-test.c

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 09 Jan 2008 16:17:55 -0800

"Leo Katzenstein" <lrk_at_google.com> writes:
> In .../subversion/tests/libsvn_fs_base/changes-test.c
>
> There is an array of transactions (lines 37-38) with transactions "0" through
> "5",
> yet in the standard_changes array (lines 39-59) shows transactions "0" through
> "6".
>
> Why aren't transaction id "6" seen? What is going on here?

Probably just an oversight by someone, thanks for finding it. (And
hi, Leo!)

Mike Pilato is about to test this patch:

[[[
* subversion/tests/libsvn_fs_base/changes-test.c
  (standard_txns): Expand to include the last txn in standard_changes.

Found by: Leo Katzenstein <lrk{_AT_}google.com>
]]]

Index: subversion/tests/libsvn_fs_base/changes-test.c
===================================================================
--- subversion/tests/libsvn_fs_base/changes-test.c (revision 28830)
+++ subversion/tests/libsvn_fs_base/changes-test.c (working copy)
@@ -34,8 +34,8 @@
 
 
 /* Helper functions/variables. */
-static const char *standard_txns[6]
- = { "0", "1", "2", "3", "4", "5" };
+static const char *standard_txns[]
+ = { "0", "1", "2", "3", "4", "5", "6" };
 static const char *standard_changes[19][6]
      /* KEY PATH NODEREVID KIND TEXT PROP */
   = { { "0", "/foo", "1.0.0", "add", 0, 0 },

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-09 22:18:24 CET

This is an archived mail posted to the Subversion Dev mailing list.