Re: [PATCH] SWIG binding for better access to svn_client_get_changelists

2008-01-05 21:38:55 Joe Swatosh napisał(a):
> I can't build or test the Python or Perl bindings so I wanted to request some
> comments rather than just committing it.
> --
> Joe
>
> [[[
>
> Add a new typemap that will allow taking advantage of cmpilato's changes to
> the svn_client_get_changelists api which will return all the changelists if
> the list is NULL.
>
> * subversion/bindings/swig/include/svn_containers.swg: New typemap
> STRINGLIST_MAY_BE_NULL for Ruby.
>
> * subversion/bindings/swig/svn_client.i: Remove the apply of STRINGLIST to
> changelists and apply STRINGLIST_MAY_BE_NULL to changelists.
>
> ]]]
>
>
> Index: subversion/bindings/swig/include/svn_containers.swg
> ===================================================================
> --- subversion/bindings/swig/include/svn_containers.swg (revision 28750)
> +++ subversion/bindings/swig/include/svn_containers.swg (working copy)
> @@ -448,6 +448,10 @@
> %typemap(in) const apr_array_header_t *STRINGLIST {
> $1 = svn_swig_rb_strings_to_apr_array($input, _global_pool);
> }
> +%typemap(in) const apr_array_header_t *STRINGLIST_MAY_BE_NULL {
> + $1 = (NIL_P($input)) ? NULL :
> + svn_swig_rb_strings_to_apr_array($input, _global_pool);
> +}
> #endif
>
> /* svn_delta_path_driver() mutates its 'paths' argument (by sorting it),
> Index: subversion/bindings/swig/svn_client.i
> ===================================================================
> --- subversion/bindings/swig/svn_client.i (revision 28750)
> +++ subversion/bindings/swig/svn_client.i (working copy)
> @@ -68,7 +68,10 @@
> #endif
>
> %apply const apr_array_header_t *STRINGLIST {
> - apr_array_header_t *src_paths,
> + apr_array_header_t *src_paths
> +}
> +
> +%apply const apr_array_header_t *STRINGLIST_MAY_BE_NULL {
> apr_array_header_t *changelists
> }
>

I'm confirming that Python, Perl and Ruby bindings build correctly with this patch.

-- 
Arfrever Frehtes Taifersar Arahesis