[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: validate_eol_prop_against_file() inefficiency?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 02 Jan 2008 13:56:34 -0500

David Glasser wrote:
>>>> I see that libsvn_wc/props.c:validate_eol_prop_against_file() has been
>>>> ordered differently in trunk. What I can't figure out is why the
>>>> far-more-expensive newline consistency check was moved ahead of the
>>>> super-cheap is-binary check? Besides being really inefficient, the new
>>>> error is just not as clear.
>>>>
>>>> Was this fallout from the URL propsetting support or something?
>>> Not sure, but wasn't there also a patch recently to add validation of
>>> the eol-style values? Perhaps that is when this happened.
>> Well, I'm going to make the obvious optimization (which will restore the
>> more-obvious error message in the case presented).
>
> I'm currently running tests against a patch to fix this.

Cool. Thanks.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-01-04 06:38:25 CET

This is an archived mail posted to the Subversion Dev mailing list.