Re: [PATCH] Fix sh-compatible issue in po-update.sh

On Thu, 03 Jan 2008, Dongsheng Song wrote:

> Hi,
>
> This patch mainly fix sh-compatible issue in po-update.sh, under OpenBSD
> box:
>
> $ ./po-update.sh
> ./po-update.sh[29]: syntax error: `(' unexpected
>
>
> [[[
> * tools/po/po-update.sh:
> Remove 'function' keyword for sh-compatible.
> Add '--no-wrap' to msgmerge, minimize spurious diffs.
>
> Index: tools/po/po-update.sh
> ===================================================================
> --- tools/po/po-update.sh (revision 28724)
> +++ tools/po/po-update.sh (working copy)
> @@ -26,7 +26,8 @@
> fi
>
> pot_done=
> -function make_pot()
> +
> +make_pot()
> {
> if [ -z "$pot_done" ]; then
> echo "Building subversion.pot..."
> @@ -60,7 +61,7 @@
> fi
> }
>
> -function update_po()
> +update_po()
> {
> (cd $svn_base/subversion/po &&
> for i in $1.po; do
> @@ -69,8 +70,8 @@
> # GNU gettext-tools 0.14.6 implementation) inverts the order of
> obsolete
> # messages every time it is run. Therefore, run it twice, to invert and
> # then re-invert, to minimize spurious diffs.
> - $MSGMERGE --sort-by-file --update $i subversion.pot
> - $MSGMERGE --sort-by-file --update $i subversion.pot
> + $MSGMERGE --sort-by-file --no-wrap --update $i subversion.pot
> + $MSGMERGE --sort-by-file --no-wrap --update $i subversion.pot
> done )
> }
> ]]]
>
> Could any full committer review it?
>
> Dongsheng

Dongsheng, +1 to commit. Thanks!

-- 
Daniel Rall