[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28740 - in branches/reintegrate/subversion/libsvn_fs_base: . notes util

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 03 Jan 2008 17:34:15 -0500

David Glasser wrote:
> On Jan 3, 2008 4:23 PM, <cmpilato_at_tigris.org> wrote:
>> Author: cmpilato
>> Date: Thu Jan 3 13:23:31 2008
>> New Revision: 28740

[...]

>> + MERGEINFO ::= (HAS-MERGEINFO MERGEINFO-COUNT) ;
>
> Do you ever use this MERGEINFO element?

Oops! That was left over from previous edits.

>> + noderev->mergeinfo_count =
>> + apr_atoi64(apr_pstrmemdup(pool,
>> + cur_skel->next->data,
>> + cur_skel->next->len));
>
> While this is admittedly following the pattern set by the other
> elements, I don't see why you'd need to duplicate a string that is
> immediately converted to a number.

skel data isn't NULL-terminated (or, I should say, the data member points to
address where the data begins, but that includes "the rest of the skel",
too). Maybe atoi64?() would stop parsing on the first non-numeric
character, but that's not something I wanna bank on, really.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-01-04 00:32:39 CET

This is an archived mail posted to the Subversion Dev mailing list.