Re: [PATCH] Add -p to show C function names was Re: [PATCH] Extra options for libsvn_diff

On Dec 29, 2007 2:01 PM, Justin Erenkrantz <justin@erenkrantz.com> wrote:
> On Dec 28, 2007 4:50 AM, Stefan Sperling <stsp@elego.de> wrote:
> > Just mentioning that this is what OpenBSD's diff does as well.
> >
> > And they also consider some C++/Java keywords which seems nice.
> > I guess a whole lot of Java people using subversion would
> > appreciate this, too.
>
> Clever. I'm doing mostly C++ these days, so I find this useful.
>
> r28702 just teaches libsvn_diff to skip over these keywords. We could
> teach it to emit the '(private)' etc parts that OpenBSD's diff does,
> but I don't think it is worth the hassle. -- justin

I'm not really sure that r28702 does anything useful. All it seems to
do is not print "private:" if you happen to have a diff on a line
between the "private:" and the beginning of a function. Is that
really useful without the state-tracking bit?

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org