[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28658 - in trunk/subversion: include libsvn_ra_neon libsvn_ra_serf libsvn_subr libsvn_wc

From: Peter Samuelson <peter_at_p12n.org>
Date: 2007-12-28 01:24:46 CET

[brane@tigris.org]
> +int
> +svn_ctype_casecmp(int a, int b)
> +{
> + const int A = casefold_table[(unsigned char)a];
> + const int B = casefold_table[(unsigned char)b];
> + if (A && B)
> + return (A - B);
> + else
> + return (a - b);
> +}

No need for the conditional - the following is simpler and faster.

-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
static const char casefold_table[] =
  {
    /* Identity, except {97:122} => {65:90} */
      0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15,
     16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31,
     32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
     48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,
     64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
     80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95,
     96, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79,
     80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90,123,124,125,126,127,
    128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,
    144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,
    160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,
    176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,
    192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,
    208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,
    224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,
    240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255
  };
int
svn_ctype_casecmp(int a, int b)
{
  const char A = casefold_table[(unsigned char)a];
  const char B = casefold_table[(unsigned char)b];
  return A - B;
}

Received on Fri Dec 28 01:24:57 2007

This is an archived mail posted to the Subversion Dev mailing list.