[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue-2987 branch: pegrev behavior for svn_fs_get_commit_and_merge_ranges

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-27 18:42:06 CET

On Dec 27, 2007 7:13 AM, Kamesh Jayachandran <kamesh@collab.net> wrote:
>
>
> David Glasser wrote:
> > Kamesh: what is the peg/copy behavior for
> > svn_fs_get_commit_and_merge_ranges supposed to be (for the merge
> > target)?
> >
> > (a) If the target is deleted and created in an unrelated way between
> > the beginning and end of the range, shouldn't it just return
> > information about the pegged version?
> >
>
> Yes it should follow the right line of history.
>
> > (b) If the target is copied from somewhere else during the range,
> > should it follow the copy backwards and given information about the
> > earlier version of the path?
> >
>
> Yes it should follow the right line of history.
> > I'm pretty sure (a) should be true but isn't (and since there's no
> > deletion in the sqlite schema, can't be until we fix that or use an
> > in-FS way of getting the information).
>
> I am not sure whether I understood you.
> I use 'location segments report' to trace the right line of history.
> I think deletions are marked as NULL path segments and hence no
> confusion over which I don't make a call to
> 'get-commit-and-merge-ranges' report.

OK. So are you saying that this isn't an issue because you always
make sure to call the get-commit-and-merge-ranges FS API with paths
that have been previously checked to be a single location segment? In
that case the FS API should be documented to state that the caller
must ensure that's the case.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 27 18:48:29 2007

This is an archived mail posted to the Subversion Dev mailing list.