[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add -p to show C function names was Re: [PATCH] Extra options for libsvn_diff

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2007-12-27 14:48:55 CET

On Dec 26, 2007 2:30 PM, Justin Erenkrantz <justin@erenkrantz.com> wrote:
> [ Going way way back into the time machine.... ]
>
> On Feb 16, 2006 12:45 PM, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> > On 2/16/06, Julian Foad <julianfoad@btopenworld.com> wrote:
> >
> > > I don't know. Again, it's a matter of how we look at the situation. I think
> > > that if we add this then we should be willing to add "--show-pascal-function",
> > > "--show-xml-element", "--show-python-function", "--show-docbook-lite-section",
> > > and so on whenever people want them. I'm serious, and maybe that's OK.
> >
> > I would be perfectly willing to add such features if:
> >
> > 1) They didn't overly complicate the diff code
> > 2) They didn't come with heavyweight external dependencies
> > 3) Someone actually volunteered to write them
> > 4) They work acceptibly well
> >
> > I think the -p option fits all of those requirements.
> >
> > As for why I want to have it built in as opposed to using GNU diff,
> > well, it's partially that I like eating our own dogfood, so I use our
> > diff impl as the default, and thus when I want -p I have to add
> > --diff-cmd diff to my command line, and it's partly that I sometimes
> > work on platforms that don't necessarily have GNU diff installed
> > (windows, solaris, etc), and it's nice for all the same functionality
> > to be there.
>
> I'd like to resurrect this discussion - IOW, I want Subversion to
> support -p out-of-the-box to print C-style function names.

It should go without saying since Justin quoted my original mail in
favor of this change, but I'm very much +1 on it going in ;-)

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 27 14:49:11 2007

This is an archived mail posted to the Subversion Dev mailing list.