Re: [PATCH] Add -p to show C function names was Re: [PATCH] Extra options for libsvn_diff

On Dec 26, 2007 1:40 PM, David Glasser <glasser@davidglasser.net> wrote:
> On Dec 26, 2007 11:30 AM, Justin Erenkrantz <justin@erenkrantz.com> wrote:
> > I'd like to resurrect this discussion - IOW, I want Subversion to
> > support -p out-of-the-box to print C-style function names.
>
> Agreed. I always use --diff-cmd diff -x -up for this reason (and wish
> that the svn.collab.net commit mails did as well, though that's an
> orthogonal issue).
>
> I think it would be reasonable to make svn's implementation compatible
> with GNU diff's, though; the regexp it uses is /^[[:alpha:]$_]/,
> whereas the patch is essentially /^[[:alpha:]0-9]/.

Calling it a regex is being generous. The patch just calls:

                  && svn_ctype_isalnum(*curp))

Perhaps, we could improve it to:

&& (svn_ctype_isalpha(*curp) || *curp == '$' || *curp == '_')

?

Or, am I mis-groking the suggested regexp? -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 26 22:47:25 2007