[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add -p to show C function names was Re: [PATCH] Extra options for libsvn_diff

From: Sander Striker <s.striker_at_striker.nl>
Date: 2007-12-26 22:28:12 CET

On 12/26/07, Justin Erenkrantz <justin@erenkrantz.com> wrote:
> [ Going way way back into the time machine.... ]

tick... tick... tick...

> I'd like to resurrect this discussion - IOW, I want Subversion to
> support -p out-of-the-box to print C-style function names.

+1, the lack of -p is the sole reason why I still use an external diff
at times...

> Julian and C-Mike's comments almost two years ago was that it was
> unnecessary feature bloat. As I (among others) said back then, I
> think this is a tremendously useful feature. The entire unified diff
> patch is under 250 lines - I view that as outweighed by the process
> savings we can incur by supporting this out-of-the-box. We've added
> so many other less-universally helpful things since then (hello merge
> tracking!) and that continuing to exclude this should be reconsidered.
> It's not going to be 100% perfect in its identification, but let's
> not make the perfect the enemy of the far far better.
>
> Patch against trunk below. I plan to commit this unless someone
> intends to veto it.
>
> Finally, many kudos to Peter for writing this in the first place. =) -- justin

+1! And Thanks for reviving it.

Cheers,

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 26 22:29:31 2007

This is an archived mail posted to the Subversion Dev mailing list.