[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix regression tests on Turkish locale

From: Carsten Koch <Carsten.Koch_at_icem.com>
Date: 2007-12-24 14:58:18 CET

Ismail Dnmez wrote:
...
> We discussed this in depth and I think the best fix is suggested by Peter
> Samuelson, attached patch against SVN trunk just does that.

Wait... From the strcasecmp man page:

"The strcasecmp() function compares the two strings s1 and s2, ignoring the case of the characters."

So, IMHO it does not make any sense to compare the same word
with (except for the case) the same string twice.

   if (strcasecmp(word, "committed") == 0)

should have exactly the same effect as

   if ( strcasecmp(word, "committed") == 0 || strcasecmp(word, "COMMITTED") == 0)

Am I missing something here?

Carsten.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 24 14:58:47 2007

This is an archived mail posted to the Subversion Dev mailing list.