[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion 1.4.6 : 3 tests fail when locale is set to Turkish (tr_TR.UTF-8)

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-23 23:25:00 CET

Out of curiosity, how are completely non-Latin languages affected by our CLI?

Like, do Russians have to completely switch their input method in
order to type out COMMITTED in Latin?

--dave

On Dec 23, 2007 1:56 PM, Nathan Yospe <nyospe@gmail.com> wrote:
>
> On Dec 23, 2007 7:40 AM, Peter Samuelson <peter@p12n.org> wrote:
>
> > [Branko Cibej]
> > > else if (strcasecmp(word, "committed") == 0)
> > > {
> > > revision->kind = svn_opt_revision_committed;
> > > }
>
> > > The interesting thing to note here is that strcasecmp is in fact doing
> > > the right thing, since "COMMITTED" and "committed" aren't
> > > case-fold-equal in a Turkish locale. I'm not quite sure what to do here.
>
> > else if (strcasecmp(word, "committed") == 0 ||
> > strcasecmp(word, "COMMITTED") == 0)
>
> > I know this doesn't technically cover all possible cases, but I believe
> > in practice it would be close enough. It would work for Turkish, and
> > offhand I don't know of other locales that have a similar irregularity
> > with ASCII letters.
>
> The only other irregularities that would affect Latin (the script, not
> the language) text are Azeri (identical to Turkish - (tolower('I') !=
> 'i')) and Lithuanian (I and J when there are accents - not relevant).
> I think this fix, applied in the appropriate places, will address all
> potential offenders.
>
> --
>
> Nathan F. Yospe
> SAP Labs LLC
> MDM Core, Los Angeles, CA
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 23 23:25:09 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.