RE: Re: svn commit: r28624 - branches/issue-2897/subversion/libsvn_fs_util
From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-12-22 19:41:36 CET
>> if (inherit == svn_mergeinfo_inherited
>Should this variable be called get_inherited_mergeinfo instead?
Fixed in r28638.
>(Also, I don't think you'll be handling the nearest_ancestor case
Yes, Will correct it as soon as I complete the 'peg-awareness work'.
>> + "mergedrevend, inheritable, mergedfrom, "
>This will iterate over *every* mergeinfo change *everywhere* in the
Yes I am aware of it, there should be better way to achieve the same, but I don't have one now.
>> + apr_hash_set(rev_target_hash, commit_rev_ptr,
>I'd also comment that the *only* reason this is safe is that you have
>> + merge_rangelist = apr_array_make(pool, 0,
>Of course, now that you're effectively doing a "loop over every change
Thanks for your review.
This is an archived mail posted to the Subversion Dev mailing list.