[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28596 - in trunk/subversion: include libsvn_subr svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-12-20 20:25:23 CET

David Glasser wrote:
> On Dec 20, 2007 8:40 AM, <cmpilato@tigris.org> wrote:
>> Author: cmpilato
>> Date: Thu Dec 20 08:40:26 2007
>> New Revision: 28596
>>
>> Log:
>> Begin supporting multiple instances of --changelist in the
>> command-line client. For now, we'll just keep them all around in a
>> list. Once the underlying APIs learn to handle multiple changelists,
>> we'll start using the list.
>
> Hmm. It's completely non-obvious to me whether you intend multiple
> --changelist invocations to be an intersection or a union operation.

Union. Union of changelists, followed by intersection with targets.

> Either way seems reasonable to me. Also, as a user I wouldn't guess
> that this is legal at all. So this should probably be documented in
> the --changelist help output. I'm thinking something along the lines
> of
>
> --changelist ARG : operate only on members of changelist ARG
> (use multiple times to operate on multiple
> changelists)
>
> though I'm not too happy with that.

Good plan.

I didn't make this change before because I wasn't sure if all the
subcommands would, in fact, accept multiple --changelist instances. (I
looked to --revision and --change for precedent, knowing that 'svn merge'
accepts multiples there, but no other subcommands.)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Thu Dec 20 20:25:33 2007

This is an archived mail posted to the Subversion Dev mailing list.