[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav_svn__update_report and resource-walk

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-20 04:54:31 CET

On Dec 19, 2007 7:50 PM, Eric Gillespie <epg@pretzelnet.org> wrote:
> In tightening up the operational logging, I've encountered
> another mystery. dav_svn__update_report looks for
> "resource-walk" from the client, but I'm not really sure what
> that causes it to do. It doesn't really matter, though, as serf
> *never* sends this and neon has code in fetch.c:make_reporter to
> send it, but no make_reporter calls use it!
>
> It was added over 5 years ago:
>
> ------------------------------------------------------------------------
> r2680 | cmpilato | 2002-07-24 11:43:27 -0700 (Wed, 24 Jul 2002) | 28 lines
>
> Create a do_diff() RA layer vtable function.
>
> * subversion/libsvn_ra_dav/ra_dav.h
> (svn_ra_dav__do_diff): New.
>
> * subversion/mod_dav_svn/update.c
> (dav_svn__update_report): Support new 'resource_walk' attribute.
>
> * subversion/libsvn_ra_dav/fetch.c
> (make_reporter): Add 'resource_walk' argument.
> (svn_ra_dav__do_update, svn_ra_dav__do_status,
> svn_ra_dav__do_switch): Update calls to make_reporter().
> (svn_ra_dav__do_diff): New.
>
> * subversion/libsvn_ra_dav/session.c
> (dav_plugin): Add reference to svn_ra_dav__do_diff.
>
> * subversion/include/svn_ra.h
> (svn_ra_plugin_t): Add do_diff() vtable entry.
>
> * subversion/libsvn_ra_local/ra_plugin.c
> (make_reporter, svn_ra_local__do_diff): New.
> (svn_ra_local__do_update, svn_ra_local__do_switch,
> svn_ra_local__do_status): Use new make_reporter() helper.
> (ra_local_plugin): Add reference to svn_ra_local__do_diff.
>
> * subversion/libsvn_client/diff.c
> (do_merge, do_diff): Use new RA->do_diff() instead of RA->do_switch().
> ------------------------------------------------------------------------
>
> Unless I'm dense, I see no explanation in that log message of
> what this resource-walk is supposed to do. As far as I can tell,
> this code is completely dead. Well, except for pre-1.2 clients,
> I guess?
>
> Thanks.

I found this code a couple of months ago, was concerned about its
interaction with something new (depth?), and eventually realized it
was pretty dead. Wasn't sure what to do though.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 20 04:54:42 2007

This is an archived mail posted to the Subversion Dev mailing list.