[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24563 - in trunk/subversion/bindings/swig: . python/libsvn_swig_py

From: David James <james_at_cs.toronto.edu>
Date: 2007-12-19 19:20:17 CET

Hi Eric,

Nice work on the Python bindings! This is an old commit but I have a
few small nits which still apply.

On Apr 12, 2007 1:07 PM, <epg@tigris.org> wrote:
> + result = PyObject_CallFunction(function, (char *)"OsO&",
> + svn_swig_NewPointerObjString(parent_baton,
> + "void *",
> + application_py_pool),
> + path, make_ob_pool, pool);

Indentation is a little off here (the application_py_pool line doesn't
line up with the "void *").

> + if (svn_swig_ConvertPtr(result, dir_baton, svn_swig_TypeQuery("void *")) == -1)
> + {
> + err = type_conversion_error("void *");
> + }

Could you use svn_swig_ConvertPtrString(result, dir_baton, "void *")
here instead? It's a little shorter.

NOTE: On a related note, we probably should also fix up make_ob_pool
and DECLARE_SWIG_CONSTRUCTOR to use svn_swig_NewPointerObjString
instead of svn_swig_NewPointerObj.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 19 19:20:28 2007

This is an archived mail posted to the Subversion Dev mailing list.