[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28504 - branches/reintegrate/subversion/libsvn_fs_fs

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-12-16 19:02:41 CET

Erik Huelsmann wrote:
> On Dec 15, 2007 10:12 PM, <blair@tigris.org> wrote:
>> Author: blair
>> Date: Sat Dec 15 13:12:07 2007
>> New Revision: 28504
>>
>> Log:
>> Instead of using %llu for a apr_int64_t, use APR_INT64_T_FMT which
>> works correctly with 64-bit compiles.
>>
>> * subversion/libsvn_fs_fs/dag.c
>> (svn_fs_fs__dag_increment_mergeinfo_count):
>> s/llu/APR_INT64_T_FMT/g.
>>
>>
>> Modified:
>> branches/reintegrate/subversion/libsvn_fs_fs/dag.c
>>
>> Modified: branches/reintegrate/subversion/libsvn_fs_fs/dag.c
>> URL: http://svn.collab.net/viewvc/svn/branches/reintegrate/subversion/libsvn_fs_fs/dag.c?pathrev=28504&r1=28503&r2=28504
>> ==============================================================================
>> --- branches/reintegrate/subversion/libsvn_fs_fs/dag.c (original)
>> +++ branches/reintegrate/subversion/libsvn_fs_fs/dag.c Sat Dec 15 13:12:07 2007
>> @@ -528,7 +528,7 @@
>> return svn_error_createf
>> (SVN_ERR_FS_CORRUPT, NULL,
>> _("Can't increment mergeinfo count on node-revision %s to negative "
>> - "value %llu"),
>> + "value %" APR_INT64_T_FMT),
>> idstr->data, noderev->mergeinfo_count);
>
> You can't include format specifiers in translatable strings because
> xgettext (the translatable string extractor) chokes on it.
>
> The right way to do it would be to
> _("value %s"), apr_psprintf("%" APR_INT64_T_FMT, noderev->mergeinfo_count)

It would be nicer to have xgettext use cpp on the source code before processing
it. Is there a way we can do that?

Does our build system require using configure before using xgettext? We could
create a source tree with cpp processed .c files and have xgettext process that.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 16 19:03:11 2007

This is an archived mail posted to the Subversion Dev mailing list.