Re: Changelists: the next generation

On Oct 16, 2007 12:02 AM, Jack Repenning <jrepenning@collab.net> wrote:
>
> On Oct 15, 2007, at 7:12 PM, David Glasser wrote:
>
> > Should [svn changelist '' foo] give an error, or just give the same
> > message as
> > "svn cl --remove"?
>
> It doesn't seem to me that one could say, with a straight face,
> "changelist '' is a handy alias for changelist --remove." It's not
> convincing UI, it just looks like something that happened because no
> one thought about the possibility. (Which is, of course, not too
> surprising, since ...) So I'd say it would be better to return an
> error.
>
> Are there any rules about changelist names? Total length, forbidden
> characters, anything like that? There seem to be. For instance, I
> tried sucking the entire content of some random file (contains the
> output of "du /", for some reason) in as the cl name and got "Error
> resolving case," whatever that means. So, if I can't have a cl whose
> name is the output of "du /", it's not unreasonable also to forbid a
> cl named ''.
>
> It might even be a good thing if these rules were a bit more strict.
> For instance, this is a pretty silly, but apparently legal (since I
> did it) situation:
>
> > svn stat
> S Documents
>
> --- Changelist '1
> 2
> 3
> 4
> 5
> 6
> 7
> 8
> 9
> 10':
> K .bashrc
>
>
> Not to mention:
>
> > svn stat
> S Documents
>
> --- Changelist '
>
>
>
>
>
> ':
> K .bashrc

This is now issue 3044.

I propose that we introduce a svn_wc_changelist_name_is_valid API, and
in 1.5 we use the same rules as in svn_prop_name_is_valid. If our
users cry out for allowing spaces in changelist names, we can allow
that in 1.6. I also think we should forbid changelists starting with
svn: in case we come up with a clever idea for a semantically special
changelist later; we'd check this with svn_wc_is_svn_changelist.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org