Re: [PATCH] Fix for reverting broken softlinks

On Dec 7, 2007 12:14 AM, David O'Shea <david.oshea@s3group.com> wrote:
> On 06/12/2007 12:49, Stefan Sperling wrote:
> > On Thu, Dec 06, 2007 at 11:02:10AM +0000, David O'Shea wrote:
> >> On 05/12/2007 23:55, Stefan Sperling wrote:
> >>> On Wed, Nov 28, 2007 at 09:36:25AM +0000, David O'Shea wrote:
> >>>> The diff is against a 1.4.5 tarball, as I cannot check out the trunk
> >>>> from here. I hope this isn't a problem.
> >>> It's not a big problem. The diff applies to current trunk with
> >>> a tiny bit of fuzz and one very minor reject.
> >>>
> >>> But for me, the test passes whether or not I patch questions.c with
> >>> your change (on FreeBSD 6.2). This does not seem right.
> >>>
> >>> Can you reproduce this? Could you take a look at the test again
> >>> and verify that it is correct?
> >> Strange. It does fail for me here without the patch.
> >
> > Just checked again to make sure:
> > It does fail for me, too, but only in 1.4.4, not on trunk.
> > Seems like this has been fixed in trunk?
>
> You're right - it passes for me on an unpatched trunk checked out yesterday.
>
> Looks like this one is already fixed for 1.5 then!

So is the resolution here that trunk does not have this bug?

Is it still the case that your test would be a useful addition to the
trunk test suite?

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org