Re: [PATCH] Out of bounds array access in hooks.c

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-12-10 23:22:37 CET

"David Glasser" <glasser@davidglasser.net> writes:
> On Dec 10, 2007 10:10 AM, Daniel <danielsh@fastmail.fm> wrote:
>> Hi All,
>>
>> hooks.c declares (line 551) an array of four elements and accesses five
>> of its elements:
>
> Good catch! (Fortunately this bug is new on trunk.) r28375.

Thanks, Daniel and David. That was my bad, I think. It passed all my
testing too; I have no idea what the compiler was doing with array
allocation such that there was always room, but I wish it hadn't :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 10 23:22:54 2007

This message: [ Message body ]
Next message: Hyrum K. Wright: "Re: [PATCH] svn diff -cHEAD"
Previous message: Julian Foad: "Re: [PATCH] Fix for Issue 2723 (Core Subversion support for programatic diff Index paths)"
In reply to: David Glasser: "Re: [PATCH] Out of bounds array access in hooks.c"
Next in thread: Philip Martin: "Re: [PATCH] Out of bounds array access in hooks.c"
Reply: Philip Martin: "Re: [PATCH] Out of bounds array access in hooks.c"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ] [ By messages with attachments ]