[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't use sqlite3_db_handle

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-09 03:00:44 CET

On Dec 3, 2007 1:07 PM, Daniel Rall <dlr@collab.net> wrote:
>
> On Mon, 03 Dec 2007, David Glasser wrote:
>
> > On Dec 2, 2007 1:01 AM, Lieven Govaerts <svnlgo@mobsol.be> wrote:
> > > All python tests are failing on the mac buildslave since a week or so. I
> > > did a check to see what's happening and found that svn uses the sqlite3
> > > function sqlite3_db_handle not yet defined in the version I'm using, ie
> > > 3.1.3. sqlite3_db_handle is added in sqlite3 3.2.2.
> > >
> > > Attached patch will remove all calls to sqlite3_db_handle. Consequence
> > > is that we need to pass the db handle to all helper functions.
> >
> > If we really can't require 3.2.2, I would prefer to make the
> > svn_fs__sqlite statement-related functions take an svn_fs__sqlite_stmt
> > object which is a struct containing a sqlite3_stmt *, and a sqlite3 *,
> > rather than requiring completely redundant arguments to all of those
> > functions.
>
> I prefer this approach.

I did something like this in r28345.

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 9 03:00:54 2007

This is an archived mail posted to the Subversion Dev mailing list.