[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug in update -N hoses wc (issue #3039 )

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-12-07 00:21:13 CET

On Thu, 06 Dec 2007, David Glasser wrote:
> This bug does appear to exist on trunk. I think the basic problem is
> that we attempt to use the requested depth of the operation to tell us
> how deep we have to lock the working copy (ie, only lock the top if
> it's a shallow update), but if we're deleting a directory we need to
> have the whole directory locked.
> We could solve this by always locking all the way down, or by
> extending the lock when it is time to delete. (Man, I want a WC where
> all locks are deep because there's only one place where you need to
> lock them.) Karl, opinions?
> Repro recipe attached to issue 3039.

If we know it's a delete when taking out the lock, let's lock all the way
down. If we don't know until later, extend the lock when we figure out
we're doing a delete.

Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu Dec 6 23:20:22 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.