[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] please review: kicking off the tree-conflicts branch

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-12-03 21:38:39 CET

On Dec 3, 2007 8:50 PM, Stefan Sperling <stsp@elego.de> wrote:
> On Mon, Dec 03, 2007 at 11:32:30AM -0800, David Glasser wrote:
> > The reason it works now is that the only place to change a depth after
> > initialization is in libsvn_wc/update_editor.c(complete_directory),
> > which doesn't use svn_wc__entry_modify (which is the caller of
> > fold_entry). This is more of an explanation of why it works than why
> > it is this way, though.
>
> I'll guess I'll just keep the defines and tree-conflict related
> entry modification in svn_wc__modify_entry() for now.
> We can remove it later when it turns out we don't need it.
>
> I'm not entirely sure where exactly we'll end up updating
> the tree-conflict-data entry yet anyway.

That seems the right way to do it, especially after David explained
why it works for depth as it does. I'm sorry I wasn't able to give
more feedback, but I had kind of an emergency this weekend (spending
most of it on my family).

HTH,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 3 21:38:51 2007

This is an archived mail posted to the Subversion Dev mailing list.