[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28187 - in trunk/subversion: include libsvn_fs libsvn_fs_base libsvn_fs_fs tests/libsvn_fs

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-03 10:50:50 CET

On Dec 2, 2007 10:40 PM, Daniel Rall <dlr@collab.net> wrote:
> > What does svn_fs_change_mergeinfo offer
> > that svn_fs_change_node_prop doesn't?
>
> That sounds like a sufficient interface to me. One suggestion: instead of
> removing that C test case, keep it around, and have it call
> svn_fs_change_node_prop().

I did think about that, and in fact having C test cases would be
useful (that test case did help me track down some segfaults in my
code this week), but that particular test case seems rather hopeless.
It:

* adds mergeinfo referencing paths and revisions that don't exist

* doesn't actually do anything with the return value for one query
(other than ensure a lack of errors)

* ensures a lack of errors on a query to a path that doesn't exist

While it was probably helpful in the early prototype stage when DannyB
wrote it, it doesn't really seem to have anything valuable any more.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 3 10:51:13 2007

This is an archived mail posted to the Subversion Dev mailing list.