[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Don't use sqlite3_db_handle

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-12-02 10:01:27 CET

All python tests are failing on the mac buildslave since a week or so. I
did a check to see what's happening and found that svn uses the sqlite3
function sqlite3_db_handle not yet defined in the version I'm using, ie
3.1.3. sqlite3_db_handle is added in sqlite3 3.2.2.

Attached patch will remove all calls to sqlite3_db_handle. Consequence
is that we need to pass the db handle to all helper functions.

Lieven

[[[
Change some db helper functions to support versions of sqlite3 older
than 3.2.2.

* subversion/libsvn_fs_util/sqlite-util.h
* subversion/libsvn_fs_util/sqlite-util.c
  (step_with_expectation,
   svn_fs__sqlite_step_done,
   svn_fs__sqlite_step_row,
   svn_fs__sqlite_step,
   svn_fs__sqlite_bind_int64,
   svn_fs__sqlite_bind_text,
   svn_fs__sqlite_finalize): Change the declarations to take the 'db' as
    parameter so we can remove the calls to sqlite3_db_handle.
  (svn_fs__sqlite_reset): Remove second declaration.

* subversion/libsvn_fs_util/mergeinfo-sqlite-index.c
* subversion/libsvn_fs_util/node-origins-sqlite-index.c
  (*): Update all uses of the above functions to pass 'db' as first
argument.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Dec 2 10:01:35 2007

This is an archived mail posted to the Subversion Dev mailing list.