[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs recover and missing revprop

From: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
Date: 2007-12-01 18:29:57 CET

> That sounds good. IIRC, the current implementation does an exponential search
> for the largest missing revision, then a binary search for the largest existing
> revision.
> So the recover instead should do an incremental search from revision 0 to ensure
> that all revs and revprops exist. I think this is necessary because you can
> have a backup tool that backed up all the revs but was in the middle of backing
> up the revprops, or vis-versa.


The initial patch I've submitted to this does not alter the way you've
done your exponential search and works completely within the
constraints you've set. I can easily modify your code and extend it
to do the revs/revprops check for each revision, which makes the most
sense and could then be used for 'svnadmin verify'. Do you mind
looking at the second patch I submitted to Issue 2992 and reviewing it
as-is? Once we get that patch applied, I'll expand it.

Take care,


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 1 18:30:07 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.