Re: svn commit: r27982 - in branches/issue-2897/subversion: include include/private libsvn_client libsvn_fs libsvn_fs_base libsvn_fs_fs libsvn_fs_util libsvn_ra libsvn_ra_local libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn libsvn_repos mod_dav_svn mod_dav_svn/reports svnserve tests/cmdline

Kamesh Jayachandran <kamesh@collab.net> writes:
> Other 2 public functions also was having such a duplicate
> DocString. Fixed in r28114.

Thanks.

>> get_parent_target_path_having_mergeinfo()'s doc string doesn't mention
>> every parameter. (As I page through the diff, I'll look for other
>> functions that have this problem.) A doc string should leave no
>> questions unanswered -- at a minimum, that usually means documenting
>> exactly what each parameter does. I can't stress this enough: most
>> likely, whoever reads your code will not understand the problem space
>> as well as you do. We need those doc strings to fill in the gaps in
>> our knowledge! :-)
>
> Fixed in r28115.

And thanks again.

> Yes it seems like an oversight in neon, serf uses the macros.

Okay. I'll fix it in neon on trunk right, and port to the branch.

Continuing review...

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 28 20:56:27 2007