[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28023 - in trunk: . subversion/libsvn_repos

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-11-28 03:22:05 CET

glasser@tigris.org writes:
> --- trunk/subversion/libsvn_repos/delta.c (original)
> +++ trunk/subversion/libsvn_repos/delta.c Sun Nov 25 23:47:00 2007
> @@ -238,6 +238,10 @@
> return svn_error_create(SVN_ERR_FS_PATH_SYNTAX, 0,
> _("Invalid target path"));
>
> + if (depth == svn_depth_exclude)
> + return svn_error_create(SVN_ERR_REPOS_BAD_ARGS, NULL,
> + _("Delta depth 'exclude' not supported"));
> +
> /* Calculate the fs path implicitly used for editor->open_root, so
> we can do an authz check on that path first. */
> if (*src_entry)
>
> --- trunk/subversion/libsvn_repos/reporter.c (original)
> +++ trunk/subversion/libsvn_repos/reporter.c Sun Nov 25 23:47:00 2007
> @@ -1294,6 +1294,10 @@
> svn_boolean_t start_empty,
> const char *lock_token, apr_pool_t *pool)
> {
> + if (depth == svn_depth_exclude)
> + return svn_error_create(SVN_ERR_REPOS_BAD_ARGS, NULL,
> + _("Depth 'exclude' not supported for link"));
> +
> return write_path_info(baton, path, link_path, rev, depth,
> start_empty, lock_token, pool);
> }
> @@ -1369,6 +1373,10 @@
> report_baton_t *b;
> const char *tempdir;
>
> + if (depth == svn_depth_exclude)
> + return svn_error_create(SVN_ERR_REPOS_BAD_ARGS, NULL,
> + _("Request depth 'exclude' not supported"));
> +
> /* Build a reporter baton. Copy strings in case the caller doesn't
> keep track of them. */
> b = apr_palloc(pool, sizeof(*b));

For a moment, I thought these should be replaced with

   svn_error_create("... '%s' ...", svn_depth_to_word(svn_depth_exclude));

But then I realized your way is friendlier to translators.

But *then* I realized that we don't translate 'exclude' in our UI (for
example, as the argument to the --depth= option), so maybe being
translation-friendly doesn't matter in this case.

Thoughts?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 28 03:22:21 2007

This is an archived mail posted to the Subversion Dev mailing list.